Extract revert messages #6226
Merged
Extract revert messages #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,4 +106,36 @@ private string DefaultErrorMessage(ReadOnlySpan<byte> span) | |||
| return null; | |||
| } | |||
| } | |||
|
|
|||
| private unsafe string? TryUnpackRevertMessage(ReadOnlySpan<byte> span) | |||
There was a problem hiding this comment.
Shouldn't this be unified with TryGetErrorMessage? Looks similar.
There was a problem hiding this comment.
They are similar but not the same:
- A specific prefix is required.
- The span has a required minimum length, not a specific length.
- The returned error message is decoded as UTF8.
Still, maybe there's something to be done to reduce the amount of code. What do you think @benaadams?
LukaszRozmej
approved these changes
Oct 26, 2023
|
We could and maybe should do that with ABI, but this is bigger refactor, so lets go with this for now. |
s1na
reviewed
Oct 30, 2023
| @@ -18,8 +19,25 @@ public class TransactionSubstate | |||
| private const string Revert = "revert"; | |||
|
|
|||
| private const int RevertPrefix = 4; | |||
| private const int WordSize = EvmPooledMemory.WordSize; | |||
|
|
|||
| private const string RevertedErrorMessagePrefix = "Reverted "; | |||
There was a problem hiding this comment.
If there was an extra colon in the prefix, i.e. Reverted: {message} this would become compatible with Geth. I want to point it out since you're already making a breaking change.
There was a problem hiding this comment.
There's an ongoing discussion on standarization of error messages: ethereum/execution-apis#463.
kamilchodola
added a commit
that referenced
this pull request
Jan 21, 2024
This reverts commit 594ab98.
LukaszRozmej
added a commit
that referenced
this pull request
Jan 21, 2024
# Conflicts: # src/Nethermind/Nethermind.Evm/TransactionSubstate.cs
OlegJakushkin
added a commit
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6224
Changes
reverterror messages.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
Some clients like
etherjstry to decode error messages on a per client basis in an ad-hoc fashion given that there is currently no standarized way to return errors foreth_estimateGas(see ethereum/execution-apis#463). This PR might affect clients that perform such decoding.