Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blob gas instead of count #6229

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Oct 27, 2023

All blob calculations should use blob gas and do not rely on max blob count to be consistent

Changes

  • Use blob gas instead of count

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 force-pushed the hotfix/use-gas-not-count-for-blobs-calc branch from 724b7d9 to 708a00a Compare October 27, 2023 15:28
@flcl42 flcl42 marked this pull request as ready for review October 27, 2023 15:29
@flcl42 flcl42 force-pushed the hotfix/use-gas-not-count-for-blobs-calc branch from 708a00a to a96f931 Compare October 27, 2023 15:34
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it, makes it less clear. Why the change?

@flcl42
Copy link
Contributor Author

flcl42 commented Oct 27, 2023

I don't like it, makes it less clear. Why the change?

  1. The spec mentions gas only, not blob count
  2. It's better to maintain only one type of limit, and as we decided to parametrise max blob gas per block, let's stick to it

@marcindsobczak
Copy link
Contributor

I don't like it, makes it less clear. Why the change?

  1. The spec mentions gas only, not blob count
  2. It's better to maintain only one type of limit, and as we decided to parametrise max blob gas per block, let's stick to it

But MaxBlobGasPerBlock is set as MaxBlobGasPerBlock = GasPerBlob * MaxBlobsPerBlock so in case of future changes we would only need to change MaxBlobsPerBlock. IMO this change is decreasing readability of the code and I don't like it (I'm the person who introduced MaxBlobsPerBlock), but it is a minor implementation detail so if you have a big preference to go this way, I don't mind

@flcl42
Copy link
Contributor Author

flcl42 commented Oct 30, 2023

I don't like it, makes it less clear. Why the change?

The current reason is that blob count did not change with custom max blob gas settings for gnosis which led to a block production issue

@flcl42 flcl42 marked this pull request as draft October 30, 2023 09:09
@flcl42 flcl42 force-pushed the hotfix/use-gas-not-count-for-blobs-calc branch 2 times, most recently from 2815182 to f149583 Compare October 31, 2023 10:39
@flcl42 flcl42 force-pushed the hotfix/use-gas-not-count-for-blobs-calc branch from f149583 to 37aee8b Compare October 31, 2023 10:48
@flcl42 flcl42 marked this pull request as ready for review October 31, 2023 10:49
@flcl42 flcl42 merged commit 3095d01 into master Oct 31, 2023
61 checks passed
@flcl42 flcl42 deleted the hotfix/use-gas-not-count-for-blobs-calc branch October 31, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants