Fix missed release span on column db #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
approved these changes
Nov 27, 2023
MarekM25
approved these changes
Nov 27, 2023
LukaszRozmej
approved these changes
Nov 28, 2023
| @@ -591,7 +593,10 @@ internal Span<byte> GetSpanWithColumnFamily(ReadOnlySpan<byte> key, ColumnFamily | |||
| { | |||
| Span<byte> span = _db.GetSpan(key, cf); | |||
| if (!span.IsNullOrEmpty()) | |||
| { | |||
| Interlocked.Increment(ref _allocatedSpan); | |||
There was a problem hiding this comment.
Do we want to keep that in the prod (non-test) code?
There was a problem hiding this comment.
Ah, I suppose we should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DangerousReleaseMemoryimplementation introduced by Refactor/combine idbwithspan with idb #6232 .Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing