Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cancun] fix BlobBaseFee not consistent with geth when ExcessBlobGas is null #6320

Merged
merged 4 commits into from
Dec 6, 2023
Merged

[cancun] fix BlobBaseFee not consistent with geth when ExcessBlobGas is null #6320

merged 4 commits into from
Dec 6, 2023

Conversation

smartprogrammer93
Copy link
Contributor

@smartprogrammer93 smartprogrammer93 commented Dec 4, 2023 •
edited

Fixes #6311

Changes

  • default blobgas in case excess blob gas is not set.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@smartprogrammer93 smartprogrammer93 requested review from LukaszRozmej, MarekM25 and flcl42 and removed request for LukaszRozmej and MarekM25 December 4, 2023 19:01
MarekM25
MarekM25 reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the PR name, please :)

@smartprogrammer93 smartprogrammer93 changed the title fix [cancun] fix BlobBaseFee not consistent with geth when ExcessBlobGas is null Dec 4, 2023
@smartprogrammer93 smartprogrammer93 merged commit 3d928fc into master Dec 6, 2023
62 checks passed
@smartprogrammer93 smartprogrammer93 deleted the fix/not-consistent-with-geth-implementatino-where-excess-blob-gas-is-null branch December 6, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flcl42 flcl42 flcl42 approved these changes

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@Demuirgos Demuirgos Demuirgos approved these changes

@marcindsobczak marcindsobczak marcindsobczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancun error on statetest with BLOBBASEFEE opcode
6 participants
@smartprogrammer93 @flcl42 @MarekM25 @LukaszRozmej @Demuirgos @marcindsobczak