Trie RlpStreams as structs #6584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
commented
Jan 21, 2024
| @@ -673,9 +673,12 @@ public void ReadOnly_store_returns_copies(bool pruning) | |||
| readOnlyNode.Should().NotBe(originalNode); | |||
| readOnlyNode.Should().BeEquivalentTo(originalNode, | |||
| eq => eq.Including(t => t.Keccak) | |||
| .Including(t => t.RlpStream) | |||
There was a problem hiding this comment.
Isn't happy with ref items so rearranged to test this bit below
2 tasks
LukaszRozmej
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
lookgs good, but lets wait for @asdacap to also take a look
|
|
||
| namespace Nethermind.Serialization.Rlp | ||
| { | ||
| public class RlpFactory |
There was a problem hiding this comment.
would it make sense to make it struct?
There was a problem hiding this comment.
Is class to have atomic writes on the CappedArray<byte> struct; which is {byte[],int} which otherwise could cause a concurrent reader to read the array but a different length from an earlier write for example; because the two items are not written atomicly.
asdacap
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing