Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ParityTraceActionConverter to output init on create #6606

Merged
merged 5 commits into from
Jan 24, 2024
Merged

fix ParityTraceActionConverter to output init on create #6606

merged 5 commits into from
Jan 24, 2024

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Jan 24, 2024 •
edited
Loading

Fixes #6603

Changes

  • fix serialization case

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@LukaszRozmej LukaszRozmej marked this pull request as ready for review January 24, 2024 09:50
@benaadams
Copy link
Member

Can_serialize_creation_method test need change to init also

@LukaszRozmej LukaszRozmej merged commit 1ef82af into master Jan 24, 2024
67 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/ParityTraceActionConverter-init branch January 24, 2024 11:12
LukaszRozmej added a commit that referenced this pull request Jan 24, 2024
@LukaszRozmej
fix ParityTraceActionConverter to output init on create (#6606)
eab730e
@vbaranov vbaranov mentioned this pull request Jan 24, 2024
Closed
6 tasks
marcindsobczak pushed a commit that referenced this pull request Feb 2, 2024
@LukaszRozmej @marcindsobczak
fix ParityTraceActionConverter to output init on create (#6606)
0bcefe7 
(cherry picked from commit 1ef82af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
fixed and awaiting release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect parity style trace init code serialization in v1.25.0
2 participants
@LukaszRozmej @benaadams