Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return BlockForRpc from debug_getBadBlocks #6612

Merged
merged 3 commits into from Jan 25, 2024
Merged

Return BlockForRpc from debug_getBadBlocks #6612

merged 3 commits into from Jan 25, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jan 24, 2024

Changes

  • Fix return type for debug_getBadBlocks

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  1. Enable debug module
  2. curl --request POST --url http://127.0.0.1:8545 --header 'content-type: application/json' --data '{ "method": "debug_getBadBlocks", "params": [], "id": 1, "jsonrpc": "2.0" }'

@flcl42 flcl42 marked this pull request as ready for review January 24, 2024 17:31
@flcl42 flcl42 merged commit 405591e into master Jan 25, 2024
67 checks passed
@flcl42 flcl42 deleted the fix-bad-blocks branch January 25, 2024 10:29
marcindsobczak pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants