Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Tx Hashes when serving Blocks & apply network back pressure #6636

Merged
merged 12 commits into from Jan 31, 2024
Merged

Exclude Tx Hashes when serving Blocks & apply network back pressure #6636

merged 12 commits into from Jan 31, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Jan 29, 2024 •
edited

Resolves #6556
Resolves #6559
Resolves #6558
Resolves #4625
Resolves #4802

Previous

image

After

image

Previous
image

After
image

Previous
image

After
image

Changes

  • Don't generate Tx hashes or allocate transactionSequence for sync requests as they are never sent.
  • Calcuate the tx hashes in the background while generating blocks to release the memory from the transactionSequence (saved for hash generation).
  • Apply better defaults for p2p networking and enforce.
  • Don't send packets to non writable channels
  • Large GC collect more frequently

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • Optimization

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams marked this pull request as ready for review January 29, 2024 23:47
@benaadams
Copy link
Member Author

Testnest sync https://github.com/NethermindEth/nethermind/actions/runs/7714975659
Node run https://github.com/NethermindEth/nethermind/actions/runs/7715598458

@benaadams benaadams requested a review from rubo as a code owner January 30, 2024 21:57
@benaadams benaadams changed the title Exclude Tx Hashes when serving Blocks Exclude Tx Hashes when serving Blocks & apply back pressure Jan 31, 2024
@benaadams benaadams changed the title Exclude Tx Hashes when serving Blocks & apply back pressure Exclude Tx Hashes when serving Blocks & apply network back pressure Jan 31, 2024
@benaadams
Copy link
Member Author

Hive test are good

@benaadams benaadams merged commit f0ea7fc into master Jan 31, 2024
67 checks passed
@benaadams benaadams deleted the Hashes-Blocks branch January 31, 2024 14:27
@benaadams benaadams mentioned this pull request Jan 31, 2024
Closed
marcindsobczak pushed a commit that referenced this pull request Feb 2, 2024
@benaadams @marcindsobczak
Exclude Tx Hashes when serving Blocks & apply network back pressure (#…
55a6917 
…6636)

(cherry picked from commit f0ea7fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@rubo rubo Awaiting requested review from rubo rubo is a code owner

Assignees
No one assigned
Labels
bug performance
Projects
None yet
Milestone
No milestone
3 participants
@benaadams @LukaszRozmej @smartprogrammer93