Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equality tests on jsonRpc #6927

Merged
merged 5 commits into from
May 21, 2024
Merged

Fix equality tests on jsonRpc #6927

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c92b74e
Remove invalid param for equality tests
kamilchodola Apr 17, 2024
ca9b5e8
Add extra wait
kamilchodola Apr 17, 2024
93c9346
Add extra log
kamilchodola Apr 17, 2024
fe8a860
Bump timeout on rpc to get real data
kamilchodola Apr 22, 2024
8423c4b
Merge branch 'master' into kch/patch_jsonrpc_flood
kamilchodola May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions .github/workflows/rpc-comparison.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: '[JSON-RPC] Compare Nethermind between clients and versions'
vname: '[JSON-RPC] Compare Nethermind between clients and versions'

on:
workflow_dispatch:
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
"custom_machine_type": "${{ needs.verify_correctness_of_setup.outputs.custom_machine_type }}"
}
non_validator_mode: true
additional_nethermind_flags: JsonRpc.EnabledModules=[Eth,Subscribe,Trace,TxPool,Web3,Personal,Proof,Net,Parity,Health,Rpc,Debug,Admin] log=INFO
additional_nethermind_flags: JsonRpc.EnabledModules=[Eth,Subscribe,Trace,TxPool,Web3,Personal,Proof,Net,Parity,Health,Rpc,Debug,Admin] JsonRpc.Timeout=3600000 log=INFO
nethermind_repo_ref: ${{ github.ref }}
custom_run_id: ${{ github.run_id }}
network: "${{ inputs.network || 'mainnet' }}"
Expand All @@ -122,7 +122,7 @@ jobs:
"custom_machine_type": "${{ needs.verify_correctness_of_setup.outputs.custom_machine_type }}"
}
non_validator_mode: true
additional_nethermind_flags: JsonRpc.EnabledModules=[Eth,Subscribe,Trace,TxPool,Web3,Personal,Proof,Net,Parity,Health,Rpc,Debug,Admin] log=INFO
additional_nethermind_flags: JsonRpc.EnabledModules=[Eth,Subscribe,Trace,TxPool,Web3,Personal,Proof,Net,Parity,Health,Rpc,Debug,Admin] JsonRpc.Timeout=3600000 log=INFO
nethermind_repo_ref: ${{ inputs.branch_to_compare }}
custom_run_id: ${{ github.run_id }}
network: "${{ inputs.network || 'mainnet' }}"
Expand Down Expand Up @@ -319,6 +319,11 @@ jobs:
check_jsonrpc_responding "$url"
check_chain_head "$url"
fi

# Extra wait - nodes need to process a few new blocks - nice to have at least 128 of them after StateHealing
# Adding (128 - 32) * 12 seconds (-32 because we always keep 32 blocks to be processed after healing)
echo "Waiting for (128 - 32) blocks to be synced
sleep 1152

compare:
name: Compare JSON-RPC responses between clients and versions
Expand Down Expand Up @@ -410,21 +415,21 @@ jobs:
flood "$TEST" ${compare_to_other_branch_params} --rates 10 50 100 500 1000 --output "$TEST_perf_result" --duration 30 --deep-check | tee -a "$TEST_perf_result.txt"
done
else
echo "flood all ${compare_to_other_branch_params} --output equality_result_other --equality | tee output_other_branch.txt"
flood all ${compare_to_other_branch_params} --output equality_result_other --equality | tee output_other_branch.txt
echo "flood all ${compare_to_other_branch_params} --equality | tee output_other_branch.txt"
flood all ${compare_to_other_branch_params} --equality | tee output_other_branch.txt
fi

- name: Compare to INFURA Endpoint
if: env.compare_to_infura == 'true' && inputs.is_performance_check != true
run: |
echo "flood all ${compare_to_infura_params} --output equality_result_infura --equality | tee output_infura.txt"
flood all ${compare_to_infura_params} --output equality_result_infura --equality | tee output_infura.txt
echo "flood all ${compare_to_infura_params} --equality | tee output_infura.txt"
flood all ${compare_to_infura_params} --equality | tee output_infura.txt

- name: Compare to Nethermind Archive Endpoint
if: env.compare_to_archive == 'true' && inputs.is_performance_check != true
run: |
echo "flood all ${compare_to_archive_params} --output equality_result_archive --equality | tee output_archive.txt"
flood all ${compare_to_archive_params} --output equality_result_archive --equality | tee output_archive.txt
echo "flood all ${compare_to_archive_params} --equality | tee output_archive.txt"
flood all ${compare_to_archive_params} --equality | tee output_archive.txt

- name: Generate report
run: |
Expand Down