Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only lookup from dirty nodes once #6973

Merged
merged 1 commit into from
May 3, 2024
Merged

Only lookup from dirty nodes once #6973

merged 1 commit into from
May 3, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Only lookup from dirty nodes once, rather than looking up if exists, then relooking up value (i.e. twice)

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams requested a review from asdacap May 3, 2024 00:59
@benaadams benaadams merged commit 176b1df into master May 3, 2024
67 checks passed
@benaadams benaadams deleted the dirtynodes branch May 3, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdacap asdacap asdacap approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benaadams @asdacap @LukaszRozmej