save compiled contracts to localStorage

[kwkr]

Add saving compiled contract to be able to resume a development session. #178

[vercel]

@kwkr is attempting to deploy a commit to the Starknet Remix Plugin Team on Vercel.

A member of the Team first needs to authorize it.

[kwkr]

A few things that I have noticed (I'm just a beginner when it comes to StarkNet so this can also be my lack of knowledge):

• when deploying a contract, it's possible to deploy it multiple times which causes deployedInfo to be populated with duplicated data.
• the form is not allowing/makes it hard to deploy contracts without a constructor. There is always a field value_ that causes the deployment to fail. Is this expected behavior?

[rjnrohit]

A few things that I have noticed (I'm just a beginner when it comes to StarkNet so this can also be my lack of knowledge):

• when deploying a contract, it's possible to deploy it multiple times which causes deployedInfo to be populated with duplicated data.
• the form is not allowing/makes it hard to deploy contracts without a constructor. There is always a field value_ that causes the deployment to fail. Is this expected behavior?

Are you talking about this :

starknet-remix-plugin/plugin/src/features/Deployment/index.tsx

Line 455 in f18d1e9

deployedInfo: [

which is causing duplication? If yes then yeah, there is a duplication there, you can modify the code to store unique pairs

I just deployed this contract: https://codeshare.io/r49mXY and I'm able to deploy it successfully , if you are getting some error for your contract then please paste the errors here

[kwkr]

@rjnrohit Added the deduplication logic.
When it comes to the problem with the constructor, it seems like the form is not updating correctly. After deploying the contracts, when I select some new contract, the constructor field stays there. See the screenshots.

Before deploying the first contract with constructor:

After deploying it:

[rjnrohit]

I see the problem, would you able to add a fix for this ? Thanks for pointing it out @kwkr

[kwkr]

@rjnrohit , I think the problem lies within the library that is used for rendering the constructor starknet-abi-form. It seems like the form state is somehow hidden in a global state and once it's activated, it couldn't reset it from the plugin level. There seems to be some jotai atom there that is holding the value (there is some field with generic name constructor. I tried different ways to change the state by passing different abi arrays (to refresh the props) but it doesn't work. So I assume the problem is somewhere there.

[rjnrohit]

@kwkr If you want then you contribute to this repo:https://github.com/NethermindEth/starknet-abi-form as well , you can submit a PR there !

[kwkr]

@rjnrohit , okay, will do it in a separate issue then since it doesn't seem to be directly connected to this one.

[kwkr]

@rjnrohit is there anything else that needs to be done for this PR?

[rjnrohit]

Did you check the form behaviour ?

[kwkr]

@rjnrohit The form behaviour is independent of the changes in this PR. It currently exists in the official plugin version available through remix ide marketplace directly. To fix this, the starknet-abi-from would need to be released and then bumped here.

[rjnrohit]

New version of starknet-abi-form has been published, would you able to check it now?

[kwkr]

Thanks @rjnrohit ! I just pushed the update that prevents constructors from becoming stale.

[rjnrohit]

Congratulations, @kwkr! Your PR successfully made it through. 🎉🙏 Keep up the great work and continue contributing! Your efforts are truly valued