Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repeater): rename experimental-connection-reuse to ntlm #499

Merged
merged 10 commits into from
Nov 21, 2023

Conversation

mongoose79
Copy link
Contributor

@mongoose79 mongoose79 commented Nov 18, 2023

The experimental-connection-reuse option has been deprecated.

closes #500

@derevnjuk
Copy link
Member

derevnjuk commented Nov 19, 2023

@mongoose79 please follow the contributing guide:

  1. Rebase your branch onto the next; the master branch is intended to be the latest distribution channel.
  2. The commit message, as well as the Pull Request (PR) title and body, must follow the conventional commit format:
    • The commit type must be "feat" or "refactor" to properly reflect the essence of the changes; you are not fixing anything.
    • The commit scope should be provided to reflect the bounded context of the work you're doing; currently, it is omitted.
    • If you introduce breaking changes, they must be properly reflected in the PR footer according to the conventional commit specification.
  3. References to private/corporate sources are strictly forbidden in public repositories; you have to open a GitHub issue with the relevant information first.
  4. Labels must be assigned and reflect the nature of the changes made. For details, please refer to the documentation at Managing labels - GitHub Docs.
  5. As the PR owner, you must be assigned to the PR. For details, please refer to Assigning issues and pull requests to other GitHub users.

@denis-maiorov-brightsec @orubin fyi

src/Commands/RunRepeater.ts Outdated Show resolved Hide resolved
@mongoose79 mongoose79 self-assigned this Nov 19, 2023
@mongoose79 mongoose79 added the Type: enhancement New feature or request. label Nov 19, 2023
@mongoose79 mongoose79 changed the title fix: rename experimental-connection-reuse to ntlm feat(repeater): rename experimental-connection-reuse to ntlm Nov 19, 2023
@mongoose79 mongoose79 force-pushed the fix/rename-experimental-connection-reuse-to-ntlm branch from 821fc07 to 321b719 Compare November 19, 2023 08:38
@derevnjuk
Copy link
Member

  1. The PR body should reflect the essence of the changes made and their purpose. Moreover, the body must use the imperative and present tenses. Omit the body if this is clear from the short description.
- `ntlm` alias has been added to `experimental-connection-reuse`.
- A new issue has been created: https://github.com/NeuraLegion/bright-cli/issues/500
  1. The place to reference GitHub issues or other attributes is the footer. You have to utilize either smart commits or keywords like "closes" to link PR with the corresponding tickets:
- A new issue is created: https://github.com/NeuraLegion/bright-cli/issues/500
+ closes #500

@mongoose79 fyi

src/Commands/RunRepeater.ts Outdated Show resolved Hide resolved
src/Commands/RunRepeater.ts Show resolved Hide resolved
Co-authored-by: Artem Derevnjuk <artem.derevnjuk@brightsec.com>
@mongoose79 mongoose79 changed the base branch from master to next November 20, 2023 08:24
src/Commands/RunRepeater.ts Outdated Show resolved Hide resolved
src/Commands/RunRepeater.ts Show resolved Hide resolved
src/Commands/RunRepeater.ts Outdated Show resolved Hide resolved
@derevnjuk derevnjuk linked an issue Nov 20, 2023 that may be closed by this pull request
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reuseConnection: !!args.experimentalConnectionReuse,

              reuseConnection: !!args.ntlm || !!args.experimentalConnectionReuse,

Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@derevnjuk derevnjuk enabled auto-merge (squash) November 21, 2023 09:12
@derevnjuk derevnjuk merged commit f465d44 into next Nov 21, 2023
4 checks passed
@derevnjuk derevnjuk deleted the fix/rename-experimental-connection-reuse-to-ntlm branch November 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'ntlm' alias to 'experimental-connection-reuse'
3 participants