Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address PyAV deprecation warnings #31

Merged

Conversation

jpgill86
Copy link
Collaborator

Since PyAV 0.5.3 (Oct 2018) and 6.1.0 (Nov 2018), ephyviewer's video source and video viewer classes have generated deprecation warnings. This PR updates the function calls so that the deprecation warnings are no longer raised.

Because PyAV's API changes were not made backwards compatible, the changes introduced here to ephyviewer are wrapped in a try statement to allow ephyviewer to remain backwards compatible with older versions of PyAV.

Eliminates "MethodDeprecationWarning: VideoStream.seek is deprecated" for PyAV >= 6.1.0
Eliminates "AttributeRenamedWarning: VideoFrame.to_nd_array is deprecated; please use VideoFrame.to_ndarray" for PyAV >= 0.5.3
@jpgill86 jpgill86 merged commit c90b9d4 into NeuralEnsemble:master May 19, 2019
@jpgill86 jpgill86 deleted the address-pyav-deprecation-warnings branch May 19, 2019 01:48
@samuelgarcia
Copy link
Collaborator

You are my best firend here. Thank you very much :)

@jpgill86 jpgill86 added this to the 1.1.0 milestone Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants