Fix for seeking non-existent video frames beyond end of video #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_frame` was sometimes called with a `target_frame` greater than the last frame index. This could occur when dragging the navigation slider all the way to the end, or when trying to step beyond the end of the video. This caused `get_frame_absolut_seek` to spend 250 iterations in its `reseek` loop, and the video would freeze for many seconds until this loop completed. This commit adds a check to `get_frame`: if the `target_frame` exceeds the final frame index, the final frame is fetched instead.
|
Cool, you are taking teh leadrship for teh video player : cool!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_framewas sometimes called with atarget_framegreater than the last frame index. This could occur when dragging the navigation slider all the way to the end, or when trying to step beyond the end of the video. This causedget_frame_absolut_seekto spend 250 iterations in itsreseekloop, and the video would freeze for many seconds until this loop completed.This commit adds a check to
get_frame: if thetarget_frameexceeds the final frame index, the final frame is fetched instead.