Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Some steps rely too much on numpy #267

Closed
guillaume-chevalier opened this issue Feb 19, 2020 · 0 comments
Closed

Bug: Some steps rely too much on numpy #267

guillaume-chevalier opened this issue Feb 19, 2020 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right
Milestone

Comments

@guillaume-chevalier
Copy link
Member

@alexbrillant please notice this to avoid using numpy.

It's not for no reason that there is a package neuraxle.steps.numpy for numpy steps: regular steps should NOT use numpy, or at least avoid to use it as much as possible to keep Neuraxle generic.

Describe the bug
Too many steps use numpy where they shouldn't

To Reproduce
Use a StepClonerForEachDataInput or a FlattenForEach

Expected behavior
The input data may be lists of strings or other types that are possibly incompatible with numpy or of discontinuous nested shapes

Additional context
Don't call np.array in the data containers of the handle methods.

@guillaume-chevalier guillaume-chevalier added bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right labels Feb 19, 2020
@guillaume-chevalier guillaume-chevalier added this to the 0.3.2 milestone Feb 19, 2020
@guillaume-chevalier guillaume-chevalier self-assigned this Feb 19, 2020
alexbrillant pushed a commit to alexbrillant/Neuraxle that referenced this issue Sep 3, 2020
alexbrillant pushed a commit to alexbrillant/Neuraxle that referenced this issue Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant