Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Clustering and FeatureExtraction inherit from TimeSeries #112

Closed
bendichter opened this issue Jan 25, 2018 · 5 comments
Closed

make Clustering and FeatureExtraction inherit from TimeSeries #112

bendichter opened this issue Jan 25, 2018 · 5 comments
Assignees
Milestone

Comments

@bendichter
Copy link
Contributor

I'd like to link Epochs with Clustering objects, but I can't because they are not TimeSeries objects. They have the necessary components-- timestamps and data (where the data is the cluster number id) so it should be doable to make the TimeSeries objects without changing the pynwb API.

@oruebel
Copy link
Contributor

oruebel commented Jan 31, 2018

@bendichter generally I think if what used to be an "Interface" in NWB 1.x looks and feels like a TimeSeries then we should have a look at whether it should become one. I need to have a look at the implications of this for these types to make sure we don't add any new requirements to these types that will break things. Let me have a look and get back to you.

@bendichter
Copy link
Contributor Author

Great, thanks. Making these objects TimeSeriess will have two benefits for me. 1) I can put them in acquisition if appropriate and 2) I can attach epochs to them

@oruebel
Copy link
Contributor

oruebel commented Jan 31, 2018

@bendichter I agree with 2) and more broadly speaking, I think the advantage lies in the ability to unify APIs for these objects. Re 1), I think that would be more of an unintended side-effect. Clustering and FeatureExtraction are usually not raw acquistions so putting them there does not seem right.

@bendichter
Copy link
Contributor Author

bendichter commented Jan 31, 2018 via email

@neuromusic
Copy link

Clustering and FeatureExtraction are usually not raw acquistions

but they can be, e.g. http://ieeexplore.ieee.org/document/7933210/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants