Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make_a_release.rst #1720

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Update make_a_release.rst #1720

merged 3 commits into from
Jul 11, 2023

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Jul 11, 2023

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Update the links in make_a_release.rst to pass the CheckExternalLinks action.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Run the action for external links.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1
Copy link
Collaborator Author

Fix #1719

@mavaylon1 mavaylon1 marked this pull request as ready for review July 11, 2023 16:34
@mavaylon1 mavaylon1 merged commit aae7d78 into dev Jul 11, 2023
20 of 21 checks passed
@mavaylon1 mavaylon1 deleted the link branch July 11, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants