Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_extra=True to NWBFile.add_x_column #1861

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Add allow_extra=True to NWBFile.add_x_column #1861

merged 7 commits into from
Mar 22, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Mar 14, 2024

Motivation

Fix #1860. TODO: add roundtrip test

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (751983b) to head (9c3c171).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1861   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          27       27           
  Lines        2661     2661           
  Branches      699      699           
=======================================
  Hits         2447     2447           
  Misses        142      142           
  Partials       72       72           
Flag Coverage Δ
integration 71.06% <100.00%> (+0.26%) ⬆️
unit 84.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly marked this pull request as draft March 14, 2024 21:06
@rly rly changed the title [WIP] Add allow_extra=True to NWBFile.add_x_column Add allow_extra=True to NWBFile.add_x_column Mar 22, 2024
@rly
Copy link
Contributor Author

rly commented Mar 22, 2024

I also added a function to help make test extensions and load them into type maps. That was significantly more work than fixing the bug in the first place, but now we can be sure that the custom column class with extra attributes can be roundtripped and exported correctly.

@rly rly requested a review from oruebel March 22, 2024 18:45
@rly rly marked this pull request as ready for review March 22, 2024 18:45
@rly rly enabled auto-merge (squash) March 22, 2024 18:51
@rly rly merged commit 5b80bea into dev Mar 22, 2024
22 of 23 checks passed
@rly rly deleted the rly-patch-1 branch March 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: nwbfile.add_trial_column does not allow extra kwargs
2 participants