Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config related to tests into test dir #9

Closed
naz opened this issue Nov 27, 2018 · 0 comments
Closed

Move config related to tests into test dir #9

naz opened this issue Nov 27, 2018 · 0 comments
Labels
refactoring/cleanup

Comments

@naz
Copy link
Contributor

naz commented Nov 27, 2018

The configuration in this project is test specific and should only live within the test directory. Related comments here - TryGhost/NQL-old#5 (comment)
@daniellockyer daniellockyer transferred this issue from TryGhost/NQL-old Mar 1, 2022
daniellockyer added a commit that referenced this issue Mar 2, 2022
@daniellockyer
Moved test related config libs to test directories
ba62e53 
closes #13 and #9

- these config libs are only used for tests, but they get picked up as
  library code in codecov and semantically don't belong in the top-level
  dir
- this commit moves them into the test dir and fixes the paths pointing
  to them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring/cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naz @daniellockyer