Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RAR5 format #278

Closed
MrJamesFreeze opened this issue Apr 15, 2018 · 4 comments
Closed

Support for RAR5 format #278

MrJamesFreeze opened this issue Apr 15, 2018 · 4 comments

Comments

@MrJamesFreeze
Copy link

MrJamesFreeze commented Apr 15, 2018

New version of WinRAR is using new RAR5 format as default.

Thanks to that, some mods cannot be added to NMM.

Some users are not aware of this and that leave them confused.
Especially mod authors who do not use NMM.

@squid-box
Copy link
Collaborator

NMM uses (afaik) 7z, which has had support for RAR5 (extraction) since 2015.

The only reason I could think of where you'd encounter this problem is that running on a 32-bit system, NMM will only have 7za.dll which is only able to unzip ,7z files.

@MrJamesFreeze
Copy link
Author

I have Windows 10 64-bit Education (like Pro) and every RAR5 file made by WinRAR (i have nothing else to create it) on my PC or downloaded from Nexus cannot be added. With RAR4, ZIP and 7Z no problem.

@MrJamesFreeze
Copy link
Author

And I don't think that I am only one with this problem, because there was same problem with some mods from Nexus. Author then changed format (usually to ZIP) and problem was solved.

@squid-box
Copy link
Collaborator

squid-box commented May 18, 2018

Alright, so I've dug into this a bit. First of all: I've converted a small mod from 7z to a RAR5, and confirmed that the problem occurs (and Trace doesn't contain anything more than "Starting Add Mod Task").

The problem seems to lie in SevenZipSharp, as it doesn't identify the RAR5 file as a valid archive format. This doesn't seem too unreasonable as the last release of SevenZipSharp was in 2010...

I've put in a request to what seems to be the most active fork of it, if they manage to add it we could update the SevenZipSharp version used in NMM and it should work.

For anyone else looking into this, the check is in Nexus.Client.Util.Archive.IsArchive().

For testing: I've also attached FakeMods.zip, which contains two fake mods RAR'ed in the respective formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants