Stardew Valley - Multiple installs of SMAPI cause unexpected diagnostics

[Pickysaurus]

Bug Report

Summary

When multiple versions of SMAPI are installed to the same loadout, a Health Check message starts to behave unexpectedly.

If you have two SMAPIs installed (e.g. v3 and v4) but have disabled the older one, the app will report that SMAPI is disabled, even though there is a build of SMAPI enabled in the loadout.

Steps to reproduce

1. Install SMAPI twice (see screenshot)
2. Disable one of the SMAPIs
3. See the diagnostic message

What is the expected behaviour?

(What did you expect to happen instead?)

Other information

Log files can be found in these locations:

• Windows: %LOCALAPPDATA%\NexusMods.App\Logs
• Linux: ~/.local/state/NexusMods.App/Logs

Please attach both nexusmods.app.main and nexusmods.app.slim log files with the most recent dates.

[erri120]

Issue comes from using the same result from checking if SMAPI is installed, for checking if SMAPI is disabled. Relevant code:

NexusMods.App/src/Games/NexusMods.Games.StardewValley/Emitters/MissingSMAPIEmitter.cs

Lines 20 to 37 in 2e72a5f

	var optionalSmapiMod = loadout.GetFirstModWithMetadata(SMAPIMarker.Version, onlyEnabledMods: false);
	if (!optionalSmapiMod.HasValue)
	{
	yield return Diagnostics.CreateSMAPIRequiredButNotInstalled(
	ModCount: smapiModCount,
	NexusModsSMAPIUri: Helpers.SMAPILink
	);
	yield break;
	}
	var smapiMod = optionalSmapiMod.Value.Item1;
	if (!smapiMod.Enabled)
	{
	yield return Diagnostics.CreateSMAPIRequiredButDisabled(
	ModCount: smapiModCount
	);
	}

Solution is getting the first enabled SMAPI mod.