Multiple loadouts UI part1 #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Used SVG animated to spin around its center - Before scaling the Arc required manual adjustment of the thickness of the arc. - This is closer to what Figma does as well
…yout not working correctly
erri120
reviewed
Jul 9, 2024
src/NexusMods.App.UI/Controls/ModInfo/Loading/LoadingView.axaml
Outdated
Show resolved
Hide resolved
erri120
requested changes
Jul 9, 2024
src/NexusMods.App.UI/Controls/LoadoutBadge/LoadoutBadgeDesignVM.cs
Outdated
Show resolved
Hide resolved
|
I'm fine with not merging this for a while to clean this up, I just pushed what I had to move on to the bugs in the meantime, but yeah I wasn't really finished with this |
erri120
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first PR of multiple to implement designs for #401
This is a work in progress.
Includes:
FlexPaneland added a few workarounds to accomodate it.Figma design:
https://www.figma.com/file/TbJiArfCPTv9fQFIEPuwd5/%F0%9F%93%B1-Loadouts?type=design&node-id=67%3A3595&mode=design&t=lkBadJsMn6yv9fem-1
Can be found in #1180