feat(oracle): add twap to oracle and unwire pricefeed #1120

matthiasmatt · 2022-12-20T22:24:11Z

Description

Replace the pricefeed with the oracle module. Updated every tests and uses cases of pricefeed to use the oracle logic.

Purpose

Removing pricefeed and adding twap in oracle makes us reduce our codebase by 15k lines of code

NibiruHeisenberg

Overall, much cleaner in test setup. Just some minor comments.

x/oracle/keeper/keeper.go

x/oracle/keeper/querier.go

x/oracle/keeper/querier_test.go

x/perp/client/cli/cli_test.go

x/stablecoin/keeper/collateral_ratio.go

x/oracle/keeper/querier_test.go

* chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * feat(oracle): add twap to oracle and unwire pricefeed (#1120) * unwire pricefeed and add twap * refactor(perp): Remove unnecessary panics | #1 (#1126) * remove unnecessary panics in x/perp * change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * Update x/common/error_test.go Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> * fix: distribution module account name (#1131) * refactor(dex): remove unnecessary panics * refactor(stablecoin): remove unnecessary panics Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com>

* remove unnecessary panics in x/perp * refactor(dex): remove panics in liquidity.go * change log * chore: change log * refactor: remove panics from x/dex (#1133) * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * feat(oracle): add twap to oracle and unwire pricefeed (#1120) * unwire pricefeed and add twap * refactor(perp): Remove unnecessary panics | #1 (#1126) * remove unnecessary panics in x/perp * change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * Update x/common/error_test.go Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> * fix: distribution module account name (#1131) * refactor(dex): remove unnecessary panics * refactor(stablecoin): remove unnecessary panics Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com>

…sible form public fns (#1134) * remove unnecessary panics in x/perp * refactor(dex): remove panics in liquidity.go * change log * chore: change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * refactor(dex): remove unnecessary panics * refactor(stablecoin): remove unnecessary panics * refactor(perp): make calls of public fns from vpool less dangerous in x/perp * checkpoint #wip vpool * fix changelog issue from merge conflict * refactor: remove panics from x/dex (#1133) * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * feat(oracle): add twap to oracle and unwire pricefeed (#1120) * unwire pricefeed and add twap * refactor(perp): Remove unnecessary panics | #1 (#1126) * remove unnecessary panics in x/perp * change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * Update x/common/error_test.go Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> * fix: distribution module account name (#1131) * refactor(dex): remove unnecessary panics * refactor(stablecoin): remove unnecessary panics Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> * test,refactor(vpool): make it impossible to write invalid pools into state. * refactor: Make it impossible to cause panics in vpool from public fns in the perp module * chore(CHANGELOG) Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: Kevin Yang <5478483+k-yang@users.noreply.github.com>

matthiasmatt added 14 commits December 20, 2022 19:22

wip: unwire pricefeed

faec23e

wip: wire oracle to vpool and perp

2e0796a

feat: add oracle to perp module

244fcf3

feat: add oracle to stablecoin module

9d7e0c1

fix: remove pricefeed from testutil

89b6a36

chore: changelog

8393118

feat: wire oracle into the app.go

520d551

feat: add twap lookback into the app

45f7e23

wip: fix more unit tests

8069ba1

wip: every test works except clis

70fa242

wip: trying to fix cli test

e6e651c

wip: add more logs

1958b12

fix: fix cli tests

d222522

fix: fix remaining unit tests

5bb8fe9

matthiasmatt changed the title ~~wip: add twap to oracle and unwire pricefeed~~ feat(oracle): add twap to oracle and unwire pricefeed Dec 27, 2022

matthiasmatt marked this pull request as ready for review December 27, 2022 20:05

matthiasmatt requested a review from a team as a code owner December 27, 2022 20:05

matthiasmatt and others added 2 commits December 28, 2022 14:06

Merge branch 'master' into mat/add-oracle-twap

4227ada

fix: fix some simulation bug

8f93209

NibiruHeisenberg reviewed Jan 3, 2023

View reviewed changes

matthiasmatt added 4 commits January 3, 2023 10:40

fix: make calctwap function private

b10c5aa

fix: fix comment on twap calc

4c1cd02

fix: add back test that was commented out

090129c

feat: add twap tests

7cce22e

NibiruHeisenberg approved these changes Jan 3, 2023

View reviewed changes

x/oracle/keeper/querier_test.go Outdated Show resolved Hide resolved

fix: fix twap calculation

1a1bb2e

matthiasmatt enabled auto-merge (squash) January 3, 2023 22:55

matthiasmatt merged commit 602af8a into master Jan 3, 2023

matthiasmatt deleted the mat/add-oracle-twap branch January 3, 2023 23:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(oracle): add twap to oracle and unwire pricefeed #1120

feat(oracle): add twap to oracle and unwire pricefeed #1120

matthiasmatt commented Dec 20, 2022 •

edited

Loading

NibiruHeisenberg left a comment

feat(oracle): add twap to oracle and unwire pricefeed #1120

feat(oracle): add twap to oracle and unwire pricefeed #1120

Conversation

matthiasmatt commented Dec 20, 2022 • edited Loading

Description

Purpose

NibiruHeisenberg left a comment

Choose a reason for hiding this comment

matthiasmatt commented Dec 20, 2022 •

edited

Loading