refactor: remove panics from x/dex #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Unique-Divine
commented
Jan 6, 2023
•
Unique-Divine
commented
- refactor(dex): remove unnecessary panics
- refactor(stablecoin): remove unnecessary panics
- related to refactor: Remove unnecessary panics #1125
GetWhitelistedPairs
… fo CombineErrors
* unwire pricefeed and add twap
* remove unnecessary panics in x/perp * change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * Update x/common/error_test.go Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com>
Unique-Divine
changed the base branch from
master
to
realu/remove-panics-2-dex
Unique-Divine
added a commit
that referenced
this pull request
Jan 10, 2023
* remove unnecessary panics in x/perp * refactor(dex): remove panics in liquidity.go * change log * chore: change log * refactor: remove panics from x/dex (#1133) * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * feat(oracle): add twap to oracle and unwire pricefeed (#1120) * unwire pricefeed and add twap * refactor(perp): Remove unnecessary panics | #1 (#1126) * remove unnecessary panics in x/perp * change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * Update x/common/error_test.go Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> * fix: distribution module account name (#1131) * refactor(dex): remove unnecessary panics * refactor(stablecoin): remove unnecessary panics Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com>
k-yang
added a commit
that referenced
this pull request
Jan 11, 2023
…sible form public fns (#1134) * remove unnecessary panics in x/perp * refactor(dex): remove panics in liquidity.go * change log * chore: change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * refactor(dex): remove unnecessary panics * refactor(stablecoin): remove unnecessary panics * refactor(perp): make calls of public fns from vpool less dangerous in x/perp * checkpoint #wip vpool * fix changelog issue from merge conflict * refactor: remove panics from x/dex (#1133) * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * feat(oracle): add twap to oracle and unwire pricefeed (#1120) * unwire pricefeed and add twap * refactor(perp): Remove unnecessary panics | #1 (#1126) * remove unnecessary panics in x/perp * change log * chore: re-run linter * test(oracle): stop the tyrannical behavior of tally_fuzz_test.go * test(oracle): try assert.NotPanics for keys of length 0 * feat,test(common): Create StringSet for easy set management * test(oracle): Increase coverage and end the collections panics in GetWhitelistedPairs * fix(oracle): small bug in TestFuzz_PickReferencePair * test,feat(common): address PR feedback and add a more generic version fo CombineErrors * linter * Update x/common/error_test.go Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> * fix: distribution module account name (#1131) * refactor(dex): remove unnecessary panics * refactor(stablecoin): remove unnecessary panics Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> * test,refactor(vpool): make it impossible to write invalid pools into state. * refactor: Make it impossible to cause panics in vpool from public fns in the perp module * chore(CHANGELOG) Co-authored-by: Matthias <97468149+matthiasmatt@users.noreply.github.com> Co-authored-by: NibiruHeisenberg <101130700+NibiruHeisenberg@users.noreply.github.com> Co-authored-by: Kevin Yang <5478483+k-yang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.