Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my_make_scrambled_password() is not part of the MySQL API #16

Open
wferi opened this issue Nov 16, 2016 · 4 comments
Open

my_make_scrambled_password() is not part of the MySQL API #16

wferi opened this issue Nov 16, 2016 · 4 comments

Comments

@wferi
Copy link
Contributor

wferi commented Nov 16, 2016

The my_make_scrambled_password() function is exported by the MySQL client libraries "to provide backwards compatibility with applications that for legacy reasons use undocumented symbols". It isn't declared in the client header files.
See https://bugs.mysql.com/bug.php?id=80974 and https://github.com/jedisct1/pure-ftpd/issues/37 for background. A reimplementation is available as well.

@NigelCunningham
Copy link
Owner

This should now be fixed in the 0.8.x branch. Please test if you're able.

@NigelCunningham
Copy link
Owner

Hi again.

I'm thinking of just releasing 0.8.1. Any feedback on that idea? (I've received "It works for me" for the latest version with the autoconf changes).

Regards,

Nigel

@wferi
Copy link
Contributor Author

wferi commented Apr 6, 2017

Hi, I put some comments on commit 662940f 10 days ago, and still find them worth discussing. They mostly concern the generic use/presence of the embedded MD5 and SHA1 implementations. The my_make_scrambled_password() routine does not use MD5 at all, but the other code parts could, when no other implementation is available. Unless you make it a hard requirement, but then there's no use embedding them...

@NigelCunningham
Copy link
Owner

Morning.

Oh, I'm sorry. I'll look again.

Thanks!

Nigel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants