Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set timeout health check in workflows #58

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

brent-johnson
Copy link
Contributor

@brent-johnson brent-johnson commented Nov 3, 2023

Enable health parameters to be passed into workflow and task to set timeout warning notifications

Description
added health option to Workflow class

How Has This Been Tested?
tests updated to cover new functional
dev test by deploying workflows to databricks with health option

Screenshots (if appropriate):
Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    Checklist:
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asingamaneni
Copy link
Collaborator

@brent-johnson looks like there are linting issues. Can you please run make fmt in your local and the push the changes. To verify locally you can run make test

@brent-johnson
Copy link
Contributor Author

@asingamaneni Yep. Sorry about that. I'm not normally a python developer. I've added a commit that fixes the unit tests and formatting.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2af63d) 88.48% compared to head (1e6cfd3) 88.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   88.48%   88.49%           
=======================================
  Files          22       22           
  Lines        3187     3189    +2     
=======================================
+ Hits         2820     2822    +2     
  Misses        367      367           
Files Coverage Δ
brickflow/codegen/databricks_bundle.py 90.03% <ø> (ø)
brickflow/engine/task.py 94.92% <100.00%> (+0.01%) ⬆️
brickflow/engine/workflow.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asingamaneni
Copy link
Collaborator

@asingamaneni Yep. Sorry about that. I'm not normally a python developer. I've added a commit that fixes the unit tests and formatting.

Thanks much for creating the pr and making the changes.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit ae84716 into Nike-Inc:main Nov 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants