Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#30] Add Travis #39

Merged
merged 1 commit into from
May 10, 2016
Merged

[#30] Add Travis #39

merged 1 commit into from
May 10, 2016

Conversation

vitkarpov
Copy link
Collaborator

@vitkarpov vitkarpov commented May 10, 2016

Travis runs npm run-script test. Now it runs only codestyle, in the future it will be something like

npm run-script codestyle && gulp tests

@vitkarpov
Copy link
Collaborator Author

@iamakulov

@vitkarpov
Copy link
Collaborator Author

image

The green tick looks pretty ;)

language: node_js
before_script: npm run-script build
node_js:
- 0.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s also add 4 (as a LTS version) and latest.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamakulov maybe it should be just node and that's it?

Specifying node will run using the latest stable Node.js release

We don't really need to test code in nodejs, it's used only for build and tests. So seems it doesn't matter, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you’re right, let’s leave just node_js.

@iamakulov
Copy link
Collaborator

@vitkarpov Great! Added a few notes.

@vitkarpov
Copy link
Collaborator Author

vitkarpov commented May 10, 2016

@iamakulov Done

@iamakulov iamakulov merged commit 9e1fadb into NikolayRys:master May 10, 2016
@iamakulov
Copy link
Collaborator

👍

@vitkarpov vitkarpov deleted the issue-#30-CI branch May 10, 2016 08:45
@iamakulov iamakulov mentioned this pull request May 10, 2016
@iamakulov iamakulov mentioned this pull request May 10, 2016
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants