Add priority to workflow instance #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsyrjala
reviewed
Nov 23, 2019
nflow-engine/src/main/java/io/nflow/engine/workflow/instance/WorkflowInstance.java
Outdated
Show resolved
Hide resolved
jsyrjala
reviewed
Nov 23, 2019
nflow-engine/src/main/java/io/nflow/engine/workflow/instance/WorkflowInstance.java
Show resolved
Hide resolved
jsyrjala
reviewed
Nov 23, 2019
nflow-rest-api-common/src/main/java/io/nflow/rest/v1/msg/ListWorkflowInstanceResponse.java
Outdated
Show resolved
Hide resolved
jsyrjala
reviewed
Nov 23, 2019
jsyrjala
reviewed
Nov 23, 2019
efonsell
reviewed
Nov 23, 2019
nflow-engine/src/main/java/io/nflow/engine/internal/dao/WorkflowInstanceDao.java
Outdated
Show resolved
Hide resolved
|
I think it would be nice to have the default priority for new instances defined in the workflow definition (which would have default value 0) |
…'s don't have priority
ttiurani
force-pushed
the
add-priority-to-workflow
branch
from
4c973a7
to
190bace
Compare
efonsell
reviewed
Nov 25, 2019
added 2 commits
November 25, 2019 11:02
…reate them after updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
prioritytwo byte integer to thenflow_workflowtable. When an executor chooses from many available scheduled workflow instances it primarily (unfairly) schedules the workflow instance with the larger priority value, and for workflows with the same priority, the one scheduled first. Priority defaults to 0 and can also be negative. (The difference in priority integer value is not significant: 1 vs 2 is treated identically to -1000 vs 1000 – in both cases latter is executed before the former.)Database migration is documented with options to either do it with one alter table (for reasonably small workflow instance count) or in phases.
#355 adds support for specifying a default priority in the workflow definition, which is the most typical use case.