Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default priority for new workflow instances per workflow definition #355

Merged
merged 4 commits into from
Nov 25, 2019

Conversation

efonsell
Copy link
Member

No description provided.

@efonsell efonsell requested a review from ttiurani November 24, 2019 20:43
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling a297562 on default-prio into ed692b4 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling a297562 on default-prio into ed692b4 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.742% when pulling a297562 on default-prio into ed692b4 on master.

@coveralls
Copy link

coveralls commented Nov 24, 2019

Coverage Status

Coverage remained the same at 67.742% when pulling a2fb65c on default-prio into 786d591 on master.

@@ -41,6 +41,9 @@
@ApiModelProperty(value = "Delay after which workflow instance history (actions, states) can be deleted from database", required = false)
public Integer historyDeletableAfterHours;

@ApiModelProperty(value = "Default priority for new workflow instances", required = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is required=false but the raw type short?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@ttiurani ttiurani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttiurani ttiurani merged commit 62fe01f into master Nov 25, 2019
@ttiurani ttiurani deleted the default-prio branch November 25, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants