Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support querying workflows from both main tables and archive. #381

Merged
merged 50 commits into from
Jan 25, 2022
Merged

Support querying workflows from both main tables and archive. #381

merged 50 commits into from
Jan 25, 2022

Conversation

gmokki
Copy link
Member

@gmokki gmokki commented Feb 19, 2020 •
edited
Loading

No description provided.

@gmokki gmokki mentioned this pull request Feb 19, 2020
Merged
@coveralls
Copy link

coveralls commented Feb 19, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 81.708% when pulling 4fa6a7d on query-archived into 5a1f294 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.309% when pulling 698a65f on query-archived into 9713b0a on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.309% when pulling 698a65f on query-archived into 9713b0a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.309% when pulling 698a65f on query-archived into 9713b0a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.309% when pulling 698a65f on query-archived into 9713b0a on master.

@gmokki gmokki force-pushed the query-archived branch 3 times, most recently from ee4da73 to 0ecd200 Compare February 22, 2020 10:53
efonsell
efonsell reviewed Mar 8, 2020
View reviewed changes
Copy link
Member

@efonsell efonsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Querying archive tables should be configurable in nflow-explorer/src/config.js
  2. Default should be false
  3. It would be nice to be able to change the setting in Explorer UI (selected value stored in local storage)

efonsell
efonsell reviewed Mar 10, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
efonsell
efonsell reviewed Mar 10, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
efonsell
efonsell requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@efonsell efonsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add tests for WorkfowInstanceDao to check that queryArchive is obeyed
  • config for queryArchive is missing from Explorer?

nflow-engine/src/main/java/io/nflow/engine/internal/dao/WorkflowInstanceDao.java Outdated Show resolved Hide resolved
nflow-engine/src/main/java/io/nflow/engine/internal/dao/WorkflowInstanceDao.java Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
...w-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowInstanceResource.java Outdated Show resolved Hide resolved
nflow-rest-api-jax-rs/src/main/java/io/nflow/rest/v1/jaxrs/WorkflowInstanceResource.java Outdated Show resolved Hide resolved
...w-rest-api-spring-web/src/main/java/io/nflow/rest/v1/springweb/WorkflowInstanceResource.java Outdated Show resolved Hide resolved
nflow-rest-api-jax-rs/src/main/java/io/nflow/rest/v1/jaxrs/WorkflowInstanceResource.java Outdated Show resolved Hide resolved
nflow-tests/src/test/java/io/nflow/tests/MaintenanceWorkflowTest.java Outdated Show resolved Hide resolved
@gmokki gmokki force-pushed the query-archived branch 2 times, most recently from e74ce27 to 197d815 Compare April 27, 2020 12:01
gmokki and others added 5 commits January 23, 2022 19:18
@gmokki
Support querying workflows from both main tables and archive.
73598ae
@gmokki
Child workflows can be in different tables than the parent workflow
a0de2bd
@gmokki
Remove unused import
0ee87fe
@gmokki
Stream query workflows results out of rest api. (#382)
66e8cb7 
* Stream results out of rest api, lowering latency to first item. The main table query is still done synchronously, but additional queries are done on the stream lowering latency
* Performance is only lightly improved due to lower memory usage
@gmokki
Support querying workflows from both main tables and archive. Stream …
0e455e8 
…workflow query results out of rest api, which makes it faster
gmokki and others added 10 commits January 24, 2022 13:17
@gmokki @efonsell
Update CHANGELOG.md
85c410d 
Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Update CHANGELOG.md
c4fa421 
Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Update nflow-rest-api-common/src/main/java/io/nflow/rest/v1/msg/ListW…
40f0b95 
…orkflowInstanceResponse.java

Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Update nflow-rest-api-common/src/main/java/io/nflow/rest/v1/ResourceB…
6bdce8e 
…ase.java

Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Update nflow-explorer/src/config.js
b3e56b2 
Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Update nflow-engine/src/main/java/io/nflow/engine/workflow/instance/W…
4aa31c8 
…orkflowInstance.java

Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Update nflow-engine/src/main/java/io/nflow/engine/workflow/instance/W…
94f3851 
…orkflowInstance.java

Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Apply suggestions from code review
b86c696 
Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki @efonsell
Apply suggestions from code review
3fbf7d6 
Co-authored-by: Edvard Fonsell <edvard.fonsell@nitor.com>
@gmokki
Reuse same WorkflowInstanceRowMapper and WorkflowInstanceActionRowMapper
4724e9e
gmokki and others added 16 commits January 24, 2022 16:02
@gmokki
Refactor TablePrefix usage to be simpler
91638a9
@gmokki
Renable TablePrefix to NflowTables
aeb90dd
@gmokki
Remove internal method wrapper
2ace977
@gmokki
Split method that was starting to get too big
da87b0f
@efonsell
refactor
c02ad70
@efonsell
rename enum values, fix and add tests
147ace4
@efonsell
refactor
6a3b10e
@gmokki
Fix wherecondition
4048957
@gmokki
Some test fixes
14571d4
@efonsell
revert some refactoring to fix tests, clean up sql a bit
0191977
@efonsell
move string manipulation from dao to enum, cleanup
0147791
@efonsell
make sql segments more readable
61dd269
@efonsell
restore query.stateVariableKey related logic to one place
aa76298
@efonsell
move executorGroup condition adding back from helper and remove the d…
71669e6 
…uplicate from the helper method
@efonsell
Merge branch 'master' into query-archived
c59b1aa
@efonsell
return archived=true/false is queryArchive is true, otherwise return …
a8a984a 
…archived=null
efonsell
efonsell approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@efonsell efonsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me now

@gmokki gmokki merged commit 1cab6bf into master Jan 25, 2022
@gmokki gmokki deleted the query-archived branch January 25, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efonsell efonsell efonsell approved these changes

@jsyrjala jsyrjala Awaiting requested review from jsyrjala

@eputtone eputtone Awaiting requested review from eputtone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmokki @coveralls @efonsell