Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlocking password safe fails when compiling with recent gcc versions #9

Closed
FlorianUekermann opened this issue Jul 30, 2016 · 4 comments
Closed

Unlocking password safe fails when compiling with recent gcc versions #9

FlorianUekermann opened this issue Jul 30, 2016 · 4 comments
Milestone
v0.8

Comments

@FlorianUekermann
Copy link
Contributor

Sending the command that enables the pws returns a respose with status: CMD_STATUS_AES_DEC_FAILED
FlorianUekermann added a commit to FlorianUekermann/nitrokey-pro-firmware that referenced this issue Jul 30, 2016
@FlorianUekermann
Fix cases of -Wunused in CcidLocalAccess.c
29f17bf 
This includes a missing return, which fixes Nitrokey#9
@FlorianUekermann FlorianUekermann mentioned this issue Jul 30, 2016
Closed
FlorianUekermann added a commit to FlorianUekermann/nitrokey-pro-firmware that referenced this issue Jul 30, 2016
@FlorianUekermann
Fix cases of -Wunused in CcidLocalAccess.c
23985c0 
This includes a missing return, which fixes Nitrokey#9
@szszszsz szszszsz added this to the v0.8 milestone Sep 12, 2016
@szszszsz
Copy link
Member

Hi!
Could you post the compiler version you have tested?
I have tested this issue on current master with gcc 5.4 and it is not occuring. I guess the cause was misused memcpy (4daceed).

@FlorianUekermann
Copy link
Contributor Author

I suspected the same because the first wrong memcpy was exactly at this place. Didn't have time to confirm. I don't remember my gcc version. I suspect it was a bit newer than 5.4.

@szszszsz
Copy link
Member

OK, thank you. I will run tests thoroughly before closing.

@szszszsz
Copy link
Member

Issue is not occurring on latest commit. It might be also caused by not regenerating AES keys after factory reset (detailed log below).
AES_DEC_FAILED_example.txt

szszszsz added a commit that referenced this issue May 19, 2018
@szszszsz
Remove build warnings #9
c08af3a 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue May 19, 2018
@szszszsz
Remove build warnings #9
882a853 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

Fix warnings FlorianUekermann/nitrokey-pro-firmware
2 participants
@FlorianUekermann @szszszsz