Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hpack should be ran before jailbreak #421

Closed
domenkozar opened this issue Jun 11, 2019 · 5 comments · Fixed by #422
Closed

hpack should be ran before jailbreak #421

domenkozar opened this issue Jun 11, 2019 · 5 comments · Fixed by #422

Comments

@domenkozar
Copy link
Member

Otherwise jailbreak fails to find a cabal file.

hpack runs in preConfigure, jailbreak in postPatch. Maybe hpack should run in prePatch?
@domenkozar domenkozar mentioned this issue Jun 11, 2019
Merged
10 tasks
@peti
Copy link
Member

peti commented Jun 14, 2019

The change is extremely simple to make: https://github.com/NixOS/cabal2nix/blob/master/src/Cabal2nix.hs#L196. Do you have the chance to test whether moving the hpack call to prePatch actually fixes the problem? I'll be happy to merge a PR to that effect.

@domenkozar
Copy link
Member Author

@turboMaCk do you want give this one a go? :)

@turboMaCk
Copy link
Member

Sure. I can test it on this case NixOS/nixpkgs#62899 (comment)

turboMaCk added a commit to turboMaCk/cabal2nix that referenced this issue Jun 15, 2019
@turboMaCk
Run hpack in prePatch phase
0dbfaa3 
This fixes an issue when hpack is used
in combination with doJailbreak.
Before hpack run after jalbreak (preConfigure),
now it runs before (prePatch)

closes NixOS#421
turboMaCk added a commit to turboMaCk/cabal2nix that referenced this issue Jun 15, 2019
@turboMaCk
Run hpack in prePatch phase
3717fd2 
This fixes an issue when hpack is used
in combination with doJailbreak.
Before hpack run after jailbreak (preConfigure),
now it runs before (prePatch)

closes NixOS#421
@turboMaCk turboMaCk mentioned this issue Jun 15, 2019
Merged
@peti peti closed this as completed in #422 Jun 19, 2019
@peti
Copy link
Member

peti commented Jun 19, 2019

Fixed in https://hackage.haskell.org/package/cabal2nix-2.14.4.

@turboMaCk
Copy link
Member

thanks, @peti we all very appreciate the time you put into maintaining this project 👍

Profpatsch pushed a commit to Profpatsch/cabal2nix that referenced this issue Mar 7, 2022
@turboMaCk @Profpatsch
Run hpack in prePatch phase
c6d1c63 
This fixes an issue when hpack is used
in combination with doJailbreak.
Before hpack run after jailbreak (preConfigure),
now it runs before (prePatch)

closes NixOS#421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run hpack in prePatch phase turboMaCk/cabal2nix
3 participants
@peti @domenkozar @turboMaCk