Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename noHaddock = true to haddock = false in Cabal builder #63

Closed
peti opened this issue Apr 8, 2014 · 1 comment
Closed

Rename noHaddock = true to haddock = false in Cabal builder #63

peti opened this issue Apr 8, 2014 · 1 comment
Labels
enhancement

Comments

@peti
Copy link
Member

peti commented Apr 8, 2014

Let's avoid convoluted double negation of setting noHaddock = true to express haddock = false.
@jwiegley
Copy link
Contributor

Make sense.

@peti peti closed this as completed in a5db30d Jan 18, 2015
peti added a commit to peti/nixpkgs that referenced this issue Jan 18, 2015
@peti
haskell-ng: rename "noHaddock" attribute to "doHaddock"
3801147 
This makes the attribute (a) consistent with "doCheck" and friends and (b)
avoids the double negation "noHaddock = false" meaning "doHaddock = true".

Fixes NixOS/cabal2nix#63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwiegley @peti