Do not fail on .cabal files that contain Unicode (fixes #340) #341
Conversation
| Left msg -> liftIO $ do | ||
| hPutStrLn stderr "*** hpack output:" | ||
| hPutStrLn stderr hpackOutput | ||
| BS.hPutStrLn stderr hpackOutput |
There was a problem hiding this comment.
Outputting the plain ByteString here is not awesome and will result in gibberish if the locale is not set to UTF8. However, outputting the String as it was before results in an exception if the locale is e.g. c and the output contains Unicode code points > 127.
Not sure if I like the current code, but I also don't know any better options. We could do a show on hpackOutput first and then print this to stderr, but as the output is potentially very large that would not be awesome neither.
Any suggestions welcome!
| buf <- withFile file ReadMode $ \ h -> do | ||
| hSetEncoding h utf8 | ||
| hGetContents h >>= Exception.evaluate . force | ||
| let hash = printSHA256 (digestString (digestByName "sha256") buf) |
There was a problem hiding this comment.
digestString is problematic, as it depends on the locale.
|
(fix for #340) |
|
I was looking into adding a test case for this. But doing so is not trivial, as AFAICT @peti For the same reason I assume that addressing your comment from 66cb4b6 alone would not detect #333 nor #340. In addition we would need to make sure that |
|
Personally, I'd prefer a path where Anyhow, thank you for the quick fix! |
No description provided.