Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to release bounds on conditional build-depends #15

Closed
bgamari opened this issue Jun 27, 2018 · 2 comments
Closed

Fails to release bounds on conditional build-depends #15

bgamari opened this issue Jun 27, 2018 · 2 comments

Comments

@bgamari
Copy link

bgamari commented Jun 27, 2018

Consider a case like comonad's cabal file:

...

library
  build-depends:
    base                >= 4       && < 5,
    semigroups          >= 0.8.3.1 && < 1,
    tagged              >= 0.7     && < 1,
    transformers        >= 0.2     && < 0.6,
    transformers-compat >= 0.3     && < 1

  if flag(containers)
    build-depends: containers >= 0.3 && < 0.6

...

When jailbreak-cabal is run on this I see the following result:

...

library
    build-depends:
        base -any,
        semigroups -any,
        tagged -any,
        transformers -any,
        transformers-compat -any

    if flag(containers)
        build-depends:
            containers >=0.3 && <0.6
    if flag(contravariant)
        build-depends:
            contravariant >=0.2.0.1 && <2
    if flag(distributive)
        build-depends:
            distributive >=0.2.2 && <1

...

Here we see that jailbreak-cabal did not modify the conditional build-depends.

@bgamari
Copy link
Author

bgamari commented Jun 27, 2018

It seems that this was previously discussed in #7.

@peti
Copy link
Member

peti commented Jul 4, 2018

Yes, this is a known limitation.

@peti peti closed this as completed Jul 4, 2018
peti pushed a commit to NixOS/nixpkgs that referenced this issue Feb 28, 2020
If you actually look at the changelog for 1.4.2.1, you'll see that it
mentions that it was only intended for ghc-7.0.4, which is why it has
a dependency on an inconveniently old version of `unix`, which
is *also* hidden behind a flag, so that we can't jailbreak it (per
NixOS/jailbreak-cabal#15).

So the right thing to do would appear to me to be to override our
default version to 1.4.2.0, until such time as the maintainer makes a
newer release.

`ConfigFile` was collateral damage, so unmark it broken, as well as
`MissingH` itself.
peti pushed a commit to NixOS/nixpkgs that referenced this issue Feb 28, 2020
If you actually look at the changelog for 1.4.2.1, you'll see that it
mentions that it was only intended for ghc-7.0.4, which is why it has
a dependency on an inconveniently old version of `unix`, which
is *also* hidden behind a flag, so that we can't jailbreak it (per
NixOS/jailbreak-cabal#15).

So the right thing to do would appear to me to be to override our
default version to 1.4.2.0, until such time as the maintainer makes a
newer release.

`ConfigFile` was collateral damage, so unmark it broken, as well as
`MissingH` itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants