Simplify loop, feedback from @tfc and @Ericson2314

NixOS · Dec 12, 2022 · 46a211b · 46a211b
1 parent 7679d1b
commit 46a211b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/libutil/error.cc b/src/libutil/error.cc
@@ -265,11 +265,11 @@ std::ostream & showErrorInfo(std::ostream & out, const ErrorInfo & einfo, bool s
 
     // traces
     if (showTrace && !einfo.traces.empty()) {
-        for (auto iter = einfo.traces.begin(); iter != einfo.traces.end(); ++iter) {
-            oss << "\n" << "… " << iter->hint.str() << "\n";
+        for (const auto & trace : einfo.traces) {
+            oss << "\n" << "… " << trace.hint.str() << "\n";
 
-            if (iter->pos.has_value() && (*iter->pos)) {
-                auto pos = iter->pos.value();
+            if (trace.pos.has_value() && (*trace.pos)) {
+                auto pos = trace.pos.value();
                 oss << "\n";
                 printAtPos(pos, oss);