Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the repl-flake experimental feature #10103

Closed
thufschmitt opened this issue Feb 28, 2024 · 4 comments · Fixed by #10299
Closed

Remove the repl-flake experimental feature #10103

thufschmitt opened this issue Feb 28, 2024 · 4 comments · Fixed by #10299
Labels
good first issue Quick win for first-time contributors repl The Read Eval Print Loop, "nix repl" command and debugger

Comments

@thufschmitt
Copy link
Member

Is your feature request related to a problem? Please describe.

The repl-flake experimental feature was adopted to provide a migration path when changing the behaviour of nix repl (#6233 (review)), with the intent of removing it after a few releases.
More than a few releases have passed, now is time to rip off the band-aid.

(There's one issue related to its semantics, but that's specific to flakes, so it's not a blocker here)

Priorities

Add 👍 to issues you find important.

@thufschmitt thufschmitt added feature Feature request or proposal good first issue Quick win for first-time contributors labels Feb 28, 2024
@thufschmitt
Copy link
Member Author

#9868 seems to be a blocker actually

@thufschmitt thufschmitt added repl The Read Eval Print Loop, "nix repl" command and debugger and removed feature Feature request or proposal labels Feb 28, 2024
@thufschmitt thufschmitt added this to the Repl Flake stabilisation milestone Feb 28, 2024
@detroyejr
Copy link
Contributor

Looks like the issue blocking this has been resolved.

Could you confirm that a PR of this scope is what's needed?

  1. Remove any entries for repl-flakes.
  2. Remove applyDefaultNullables
  3. Fix tests in repl.sh if 2 applies.

nix repl moving foward would behave as follows:

# No longer allowed and returns the same error as nix run.
nix repl default.nix
> error: path 'default.nix' is not a flake (because it's not a directory)

nix repl --file default.nix
> Loading installable ''...
> Added 13 variables.

# Still require experimental features flag flakes.
nix repl .
> error: experimental Nix feature 'flakes' is disabled ...

# Works as before.
nix repl --extra-experimental-features flakes .

@thufschmitt
Copy link
Member Author

Could you confirm that a PR of this scope is what's needed?

1. Remove any [entries](https://github.com/NixOS/nix/blob/a22328066416650471c3545b0b138669ea212ab4/src/libutil/experimental-features.cc#L206) for repl-flakes.

2. Remove [applyDefaultNullables](https://github.com/NixOS/nix/blob/a22328066416650471c3545b0b138669ea212ab4/src/nix/repl.cc#L48)

3. Fix tests in repl.sh if 2 applies.

I confirm. And I can also say that I would be very grateful if you're willing to take care of this :)

@thufschmitt
Copy link
Member Author

Oh, there's just one extra step:

  1. Add a release note under doc/manual/rl-next

madsbv added a commit to madsbv/nix that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Quick win for first-time contributors repl The Read Eval Print Loop, "nix repl" command and debugger
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants