Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SearchPath #10539

Closed
Ericson2314 opened this issue Apr 17, 2024 · 4 comments · Fixed by #10573
Closed

Rename SearchPath #10539

Ericson2314 opened this issue Apr 17, 2024 · 4 comments · Fixed by #10573
Labels
good first issue Quick win for first-time contributors windows

Comments

@Ericson2314
Copy link
Member

Ericson2314 commented Apr 17, 2024 •
edited

As is typical on that platform, Windows defines a SearchPath macro to choose between SearchPathA and SearchPathW. The macro conflicts with our struct name.

Originally posted by @Ericson2314 in #8901 (comment)
@Ericson2314 Ericson2314 added windows good first issue Quick win for first-time contributors labels Apr 17, 2024
@Ericson2314 Ericson2314 mentioned this issue Apr 17, 2024
Merged
8 tasks
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-on-windows/1113/109

@roberth
Copy link
Member

roberth commented Apr 19, 2024

NixSearchPath, or do we have an alternate term for this concept?
Doesn't hurt to qualify it anyway. There's other search paths out there, like PATH, etc, and we interact with those too.

@Ericson2314
Copy link
Member Author

LookupPath is an option, since the docs also use that.

I would like to avoid Nix since it is already in the Nix namespace. Similarly, I regret putting Nix in NixStringContext, which was a silly mistake on my part.

@roberth
Copy link
Member

roberth commented Apr 19, 2024

Color me α-indifferent.
I'll take what the PR brings.

@RCoeurjoly RCoeurjoly mentioned this issue Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Quick win for first-time contributors windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename SearchPath to LookupPath and searchPath to lookupPath RCoeurjoly/nix
3 participants
@roberth @Ericson2314 @nixos-discourse