Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SearchPath to LookupPath and searchPath to lookupPath #10573

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

RCoeurjoly
Copy link
Contributor

Fixes #10539

Priorities and Process

Add 馃憤 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added new-cli Relating to the "nix" command repl The Read Eval Print Loop, "nix repl" command and debugger fetching Networking with the outside (non-Nix) world c api Nix as a C library with a stable interface labels Apr 20, 2024
src/libexpr/eval.hh Outdated Show resolved Hide resolved
src/libexpr/search-path.hh Outdated Show resolved Hide resolved
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I reviewed an outdated diff, or the timeline is weird. Oh well.

@roberth roberth enabled auto-merge April 21, 2024 14:41
@roberth roberth merged commit 6fd2f42 into NixOS:master Apr 21, 2024
9 checks passed
@RCoeurjoly RCoeurjoly deleted the Rename_SearchPath branch April 21, 2024 16:55
@Ericson2314
Copy link
Member

Thank you so much! It's really something special to create issues and then see volunteers do the work :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c api Nix as a C library with a stable interface fetching Networking with the outside (non-Nix) world new-cli Relating to the "nix" command repl The Read Eval Print Loop, "nix repl" command and debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename SearchPath
3 participants