Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor nit In FdSource::readUnbuffered #2169

Closed
dtzWill opened this issue May 19, 2018 · 0 comments
Closed

Minor nit In FdSource::readUnbuffered #2169

dtzWill opened this issue May 19, 2018 · 0 comments

Comments

@dtzWill
Copy link
Member

dtzWill commented May 19, 2018

n = ::read(fd, (char *) data, bufSize);

Size used in read should be len (which we currently ignore), since were writing to data not our buffer.

Happily I think we only ever actually call this where data argument is the buffer (and len is it's size),
which would explain why this didn't break things at least sometimes xD.

Even so, this should probably get fixed anyway. Please 😇 (assuming folks agree with my analysis).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant