Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether localRegistry and flagRegistry are completely used #2841

Closed
CSVdB opened this issue Apr 4, 2019 · 2 comments
Closed

Check whether localRegistry and flagRegistry are completely used #2841

CSVdB opened this issue Apr 4, 2019 · 2 comments
Labels

Comments

@CSVdB
Copy link
Contributor

CSVdB commented Apr 4, 2019

Each entry in the local and flag registries is there with the purpose of overwriting a specific dependency. If one of these entries is not used, there might be something unexpected going on, and a warning should be issued.

@CSVdB CSVdB self-assigned this Apr 8, 2019
@grahamc grahamc transferred this issue from another repository May 16, 2019
@grahamc grahamc added the flakes label May 16, 2019
@CSVdB
Copy link
Contributor Author

CSVdB commented May 18, 2019

In addition, note that the flag registry isn't actually used in updating the lockfile, only in recreating it. This must be fixed! Not sure how though.. Essentially we need to be able to detect whether a given FlakeRef was before resolved using the same flag or not..

One option would be to the depedencies influenced by the flag-registry always update, even when the rest of the lockfile isn't recreated from scratch.

CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 19, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 19, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 19, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 19, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 19, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 19, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 27, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 28, 2019
CSVdB pushed a commit to CSVdB/nix that referenced this issue Jun 28, 2019
@CSVdB CSVdB removed their assignment Aug 9, 2019
@edolstra
Copy link
Member

Closing, not clear whether we actually want this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants