Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-User Darwin Installer: No side effects before old installation check #3667

Closed
Ericson2314 opened this issue Jun 8, 2020 · 1 comment · Fixed by #4289
Closed

Multi-User Darwin Installer: No side effects before old installation check #3667

Ericson2314 opened this issue Jun 8, 2020 · 1 comment · Fixed by #4289
Labels

Comments

@Ericson2314
Copy link
Member

I think there are a few instances of the installer doing things before deciding whether to abort, which makes retrying a real pain as one has delete files over and over again.

Instances (to be edited):

  • Catalina volume and /etc/synthetic.conf /nix creation. This one macos has made especially irksome, as one can easily create /nix, but must reboot to get rid of it.
@Ericson2314 Ericson2314 added the bug label Jun 8, 2020
@abathur
Copy link
Member

abathur commented Dec 16, 2020

I'm marking #4289 as closing this, but it's not a 100% overlap with how you formulated this, so I'll edit it back out if you object.

  • I did move the volume setup process into the multi-user installer, so it does now take place after the "is-nix-installed?" check.
  • But, a previous PR (but commits unreleased) has already converted the nix-exists error into a "this may not work" sort of warning in master, so there's less of a meaningful hard wall.
  • My PR adds a ~curing process that should make the installer resilient to the existence of synthetic.conf, /nix, and the volume.
  • generic (non-Darwin) install cruft is out-of-scope, so it'll still be possible to hit hard stops on things like the /etc/*.backup-before-nix files and such (until we make some sort of phase-2 effort to extend the foundation work in this PR to all of the artifacts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants