Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The installer_test CI job is broken #7001

Open
thufschmitt opened this issue Sep 5, 2022 · 1 comment · Fixed by #7002
Open

The installer_test CI job is broken #7001

thufschmitt opened this issue Sep 5, 2022 · 1 comment · Fixed by #7002
Labels

Comments

@thufschmitt
Copy link
Member

Describe the bug

https://github.com/NixOS/nix/runs/8187933590?check_suite_focus=true (and all . For some reason the sha256 in the generated install script differs from the hash of the tarball we get from cachix since last week.

It doesn't seem totally deterministic (a9af12e got merged three days ago and has a green CI), and seems to randomly affect both the Linux and MacOS tarballs.

Running diffoscope on a pair of offending tarballs shows a timestamp mismatch somewhere:

$ nix run p\#diffoscope nix-2.12.0pre20220905_df5159e-x86_64-darwin.tar.xz /nix/store/mcj4z3ggqzvlz44xsyixlins9d388zr9-nix-binary-tarball-2.12.0pre20220905_df5159e/*.tar.xz
--- nix-2.12.0pre20220905_df5159e-x86_64-darwin.tar.xz
+++ /nix/store/mcj4z3ggqzvlz44xsyixlins9d388zr9-nix-binary-tarball-2.12.0pre20220905_df5159e/nix-2.12.0pre20220905_df5159e-x86_64-darwin.tar.xz
├── nix-2.12.0pre20220905_df5159e-x86_64-darwin.tar
│ ├── file list
│ │ @@ -1,13 +1,13 @@
│ │ --rwxr-xr-x   0 root         (0) wheel        (0)     8665 2022-09-05 09:57:45.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install
│ │ --rwxr-xr-x   0 root         (0) wheel        (0)    32687 2022-09-05 09:57:45.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/create-darwin-volume.sh
│ │ --rwxr-xr-x   0 root         (0) wheel        (0)     6685 2022-09-05 09:57:45.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install-darwin-multi-user.sh
│ │ --rwxr-xr-x   0 root         (0) wheel        (0)     5368 2022-09-05 09:57:45.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install-systemd-multi-user.sh
│ │ --rwxr-xr-x   0 root         (0) wheel        (0)    28793 2022-09-05 09:57:45.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install-multi-user
│ │ --rw-r--r--   0 root         (0) wheel        (0)    20504 2022-09-05 09:57:45.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/.reginfo
│ │ +-rwxr-xr-x   0 root         (0) wheel        (0)     8665 2022-09-05 09:32:25.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install
│ │ +-rwxr-xr-x   0 root         (0) wheel        (0)    32687 2022-09-05 09:32:25.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/create-darwin-volume.sh
│ │ +-rwxr-xr-x   0 root         (0) wheel        (0)     6685 2022-09-05 09:32:25.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install-darwin-multi-user.sh
│ │ +-rwxr-xr-x   0 root         (0) wheel        (0)     5368 2022-09-05 09:32:25.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install-systemd-multi-user.sh
│ │ +-rwxr-xr-x   0 root         (0) wheel        (0)    28793 2022-09-05 09:32:25.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/install-multi-user
│ │ +-rw-r--r--   0 root         (0) wheel        (0)    20504 2022-09-05 09:32:25.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/.reginfo
│ │  drwxr-xr-x   0 root         (0) wheel        (0)        0 1970-01-01 00:00:01.000000 nix-2.12.0pre20220905_df5159e-x86_64-darwin/store/01mj3sckpsccjs2xxkk5g7785l9q768x-libcxxabi-11.1.0/

image

I presume the tarball is occasionally built twice at slightly different times in the CI pipeline (rather than being fetched from the cache the second time), causing the discrepancy. The logical fix seems to be to just reset the timestamps to make it reproducible

@thufschmitt thufschmitt added the bug label Sep 5, 2022
thufschmitt added a commit to tweag/nix that referenced this issue Sep 5, 2022
Otherwise it isn't reproducible.

Fix NixOS#7001
@thufschmitt
Copy link
Member Author

Reopening since it seems that the error is striking again (https://github.com/NixOS/nix/actions/runs/3118058809/jobs/5057274066). Probably the fix wasn't complete

@thufschmitt thufschmitt reopened this Sep 24, 2022
Minion3665 pushed a commit to Minion3665/nix that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant