nix eval doesn't quote reserved keys

[aameen-tulip]

Describe the bug

Reserved keywords aren't quoted when printing attrsets with nix eval.

Steps To Reproduce

nix eval -f <( nix eval --expr '{ "assert" = 1; }'; );

Expected behavior

Effectively

nix eval ... \
  |sed 's/ \(assert\|with\|let\|in\(herit\)\?\|import\|or\|rec\) =/ "\1" =/';

nix-env --version output

This effects all releases through 2.13.0.

Additional context

I plan to fix and PR this issue.

[edolstra]

While this would be nice, it's important to note that the output of nix eval is not guaranteed to be a valid Nix expression. For unambiguous machine-readable output, it's better to use --json.

[balsoft]

While this would be nice, it's important to note that the output of nix eval is not guaranteed to be a valid Nix expression.

Is this documented somewhere?

The manpage says:

· By default, the evaluation result is printed as a Nix expression.

I would expect "a Nix expression" to mean "a valid Nix expression".

[aameen-tulip]

Same lol. I think I'll fix this today.

…

On Wed, Mar 22, 2023, 6:08 AM Alexander Bantyev ***@***.***> wrote: While this would be nice, it's important to note that the output of nix eval is not guaranteed to be a valid Nix expression. Is this documented somewhere? The manpage says: · By default, the evaluation result is printed as a Nix expression. I would expect "a Nix expression" to mean "a valid Nix expression". — Reply to this email directly, view it on GitHub <#7656 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXOLCEEEIOSCZLKF5ZRMMF3W5LMRRANCNFSM6AAAAAAUCYSTV4> . You are receiving this because you authored the thread.Message ID: ***@***.***>