Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EvalState::addToSearchPath, make private #8229

Closed
Ericson2314 opened this issue Apr 17, 2023 · 1 comment · Fixed by #8836
Closed

Move EvalState::addToSearchPath, make private #8229

Ericson2314 opened this issue Apr 17, 2023 · 1 comment · Fixed by #8836

Comments

@Ericson2314
Copy link
Member

  1. It is only used by the constructor to EvalState
  2. It is currently defined in the parser but not used in the parser.
    (it is parsing something, but not the language!)
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-04-17-nix-team-meeting-minutes-49/27379/1

Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Aug 16, 2023
@Ericson2314
Delete EvalState::addToSearchPath
c16ea72 
This function is now trivial enough that it doesn't need to exist.

`EvalState` can still be initialized with a custom search path, but we
don't have a need to mutate the search path after it has been
constructed, and I don't see why we would need to in the future.

Fixes NixOS#8229
@Ericson2314 Ericson2314 mentioned this issue Aug 16, 2023
Merged
8 tasks
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Aug 18, 2023
@Ericson2314
Delete EvalState::addToSearchPath
fe71faa 
This function is now trivial enough that it doesn't need to exist.

`EvalState` can still be initialized with a custom search path, but we
don't have a need to mutate the search path after it has been
constructed, and I don't see why we would need to in the future.

Fixes NixOS#8229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete EvalState::addToSearchPath obsidiansystems/nix
2 participants
@Ericson2314 @nixos-discourse