Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split utils.hh #8913

Closed
Ericson2314 opened this issue Sep 4, 2023 · 0 comments · Fixed by #8920
Closed

Split utils.hh #8913

Ericson2314 opened this issue Sep 4, 2023 · 0 comments · Fixed by #8920
Assignees
@Ericson2314
Labels
contributor-experience Developer experience for Nix contributors good first issue Quick win for first-time contributors idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. windows

Comments

@Ericson2314
Copy link
Member

utils.hh currently contains a mix of pure functions (e.g. tokenizeString) and functions to deal with the operating system (file descriptors, filesystem, signals etc.). It is also quite large.

It should be split up by topic, and downstream files should only #include the pats they need.

See also #8901. I already started splitting it up in that, to avoid a sea of CPP. But the right order in which to do things is to split it up first.
@Ericson2314 Ericson2314 added feature Feature request or proposal good first issue Quick win for first-time contributors windows contributor-experience Developer experience for Nix contributors and removed feature Feature request or proposal labels Sep 4, 2023
@Ericson2314 Ericson2314 mentioned this issue Sep 4, 2023
Merged
8 tasks
@Ericson2314 Ericson2314 added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Sep 22, 2023
@Ericson2314 Ericson2314 self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ericson2314 Ericson2314

Labels
contributor-experience Developer experience for Nix contributors good first issue Quick win for first-time contributors idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split up util.{hh,cc} obsidiansystems/nix
1 participant
@Ericson2314