refactor: move the repl input code to its own file #10083
Conversation
github-actions
bot
added
the
repl
lf-
force-pushed
the
jade/refactor-repl-input
branch
2 times, most recently
from
7d74a25
to
7abbeed
Compare
| static constexpr const char * promptForType(ReplPromptType promptType) | ||
| { | ||
| switch (promptType) { | ||
| case ReplPromptType::ReplPrompt: | ||
| return "nix-repl> "; | ||
| case ReplPromptType::ContinuationPrompt: | ||
| return " "; | ||
| } | ||
| assert(false); | ||
| } |
There was a problem hiding this comment.
the only actual new code in here
| rl_set_complete_func(completionCallback); | ||
| rl_set_list_possib_func(listPossibleCallback); | ||
| #endif | ||
| return restoreRepl; |
There was a problem hiding this comment.
This used to be a Finally in caller scope so we have to hoist it to the caller by returning it now. Nothing else is changed in this function.
|
|
lf-
force-pushed
the
jade/refactor-repl-input
branch
from
7abbeed
to
faf8fec
Compare
|
|
|
Would be fixed by: #9546 |
Merged 馃帀 |
lf-
force-pushed
the
jade/refactor-repl-input
branch
2 times, most recently
from
e97087d
to
9c56a9c
Compare
| free(vp[ac]); | ||
| free(vp); | ||
| } | ||
| throw Error("allocation failure"); |
There was a problem hiding this comment.
It is probably a bad idea/unsound to unwind through libreadline, resulting in the terminal not being reset! But I'm not fixing it in this PR as this PR is just moving code around.
|
Merge conflicts fixed and it's expected to compile; this is now reviewable. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-03-04-nix-team-meeting-minute-130/40830/1 |
This is in direct preparation for an automation mode of nix repl.
lf-
force-pushed
the
jade/refactor-repl-input
branch
2 times, most recently
from
9c56a9c
to
cc36428
Compare
Motivation
This is in preparation for #10075 which adds an automation mode to the repl that bypasses readline.
In order to make implementing that nice, I decided to do a refactoring to move all the repl input code into its own file and split it out of the repl proper. This keeps all the readline jank in one place and makes the repl more maintainable.
I split this into a separate PR to make it easier to review.
Context
Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.