Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve checked json casting #10087
Improve checked json casting #10087
Changes from 13 commits
7846c14
91cd38d
08e86ae
ca5c19c
5cc2fbf
0a40691
8284b5b
8d89c30
bd92d24
2e31f09
dff4a94
fbd750d
8525624
b6700cc
5859930
27a16f4
147d190
769a514
489a1d1
cf62af5
46814db
f829e21
f1f5846
2da5b88
1f2c792
78f42f2
52eaf26
65355fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't inline things like this. Instead we can change the JSON deserializer for
PublicKey
to use the new combinators. (And we could test that deserializer too.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that I understand that correctly this means implementing a new static method for
PublicKey::fromJSON
? ^^'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grep for
JSON_IMPL
. We want to keep that pattern.Also, How did it work before? If each on was a string, it should stay that way (at least for now). This PR shouldn't be changing behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is different thing than the one I indented, which would turn
null
tostd::nullopt
and anything else tostd::optional { <original> }
.This one is useful too, but maybe lets call it
optionalValueAt
or something. "nullable" impliesnull
but this one isn't aboutnull
at all! Just about potentially-missing fields.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I hope we will transfer from having fewer sometimes-there-sometimes-missing fields, and more explicit
null
s, so this function is hopefully just used for things we don't control and some backwards compat.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay -- makes sense! Thanks :D