Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LockedFlake::getFingerprint(): Use Input::getFingerprint() #10149

Merged
merged 2 commits into from
Mar 7, 2024
Merged

LockedFlake::getFingerprint(): Use Input::getFingerprint() #10149

merged 2 commits into from
Mar 7, 2024

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Mar 4, 2024

Motivation

Extracted from lazy-trees.

Context

Priorities and Process

Add 馃憤 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the fetching Networking with the outside (non-Nix) world label Mar 4, 2024
@edolstra edolstra merged commit 38b79da into NixOS:master Mar 7, 2024
8 checks passed
@edolstra edolstra deleted the use-flake-fingerprint branch March 7, 2024 09:18
edolstra added a commit that referenced this pull request Mar 7, 2024
@edolstra
PathInputScheme::getFingerprint(): Don't barf on relative paths
0282499 
This wasn't caught by CI because #10149 and #10152 pass
individually... It doesn't happen on lazy-trees either because we
never try to fetch relative path flakes (#10089).
@edolstra edolstra mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fetching Networking with the outside (non-Nix) world
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@edolstra