don't allow uris inside ${ ... } blocks #1019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes NixOS#1017 evaluating `nix-env -qa` and (modulo some typo problem) this doesn't seem to be used inside nixpkgs. this is a non-backward-compatible change though, 3rd party code could break because of this.
|
I think it's better here to just not allow all RFC urls, as this error also happens in functions such as |
8 tasks
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #1017
also related to #836
evaluating
nix-env -qaworked (modulo some typo problem) so this doesn't seem to be used inside nixpkgs.this is a non-backward-compatible change though, 3rd party code could break because of this.